Support for ImageFiltered widget to apply ImageFilter to children.#47489
Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom Dec 21, 2019
Merged
Support for ImageFiltered widget to apply ImageFilter to children.#47489fluttergithubbot merged 5 commits intoflutter:masterfrom
fluttergithubbot merged 5 commits intoflutter:masterfrom
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
I also still need to create some tests. |
Contributor
Author
Contributor
Author
yjbanov
approved these changes
Dec 20, 2019
Contributor
|
LGTM from the engine interaction standpoint. I left some comments on the API design, but consider them non-blocking. API LGTM if LGT @Hixie. |
38792c2 to
a52f755
Compare
Contributor
Author
|
The engine implementation for C++ has rolled into the framework repo with web stubs, and the web implementation that removes the stubs is staged in the engine roller (just waiting for the tree to go green to be rolled), so I am removing the WIP label. This PR should be ready to go. |
a52f755 to
8ac22a9
Compare
Hixie
reviewed
Dec 21, 2019
Hixie
reviewed
Dec 21, 2019
Hixie
reviewed
Dec 21, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Framework counterpart to flutter/engine#14491
Fixes #13489
The engine PR for the C++ engine has landed, and the web_ui version of the implementation should land in the next few days. This PR cannot be pushed until minimally flutter/engine@929b1ed is rolled into the framework repo and it should also wait until the fix for #47163 to roll as well.
Marked as WIP until the engine rolls happen, but it is otherwise ready for reviews.