Skip to content

Support for ImageFiltered widget to apply ImageFilter to children.#47489

Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom
flar:imagefiltered-widget
Dec 21, 2019
Merged

Support for ImageFiltered widget to apply ImageFilter to children.#47489
fluttergithubbot merged 5 commits intoflutter:masterfrom
flar:imagefiltered-widget

Conversation

@flar
Copy link
Contributor

@flar flar commented Dec 20, 2019

Framework counterpart to flutter/engine#14491
Fixes #13489

The engine PR for the C++ engine has landed, and the web_ui version of the implementation should land in the next few days. This PR cannot be pushed until minimally flutter/engine@929b1ed is rolled into the framework repo and it should also wait until the fix for #47163 to roll as well.

Marked as WIP until the engine rolls happen, but it is otherwise ready for reviews.

@flar flar requested review from Hixie, liyuqian and yjbanov December 20, 2019 01:05
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Dec 20, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flar
Copy link
Contributor Author

flar commented Dec 20, 2019

I also still need to create some tests.

@flar
Copy link
Contributor Author

flar commented Dec 20, 2019

The tests will fail until the engine changes roll into framework, but here are the golden image results I'm expecting...
image_filter_blur
image_filter_matrix

@flar
Copy link
Contributor Author

flar commented Dec 20, 2019

All implementations of the back end for this widget have landed in the Engine repo, and we're just waiting for those commits to roll to the framework repo to finalize this PR. Here is a screenshot of the new ImageFiltered running on Chrome (note that the BackdropFilter doesn't produce a blur yet on Chrome, it simply dims the background, so the ImageFiltered widget will become a preferred way to blur a background if you can use it in your app).
Screen Shot 2019-12-20 at 12 54 47 PM

@yjbanov
Copy link
Contributor

yjbanov commented Dec 20, 2019

LGTM from the engine interaction standpoint. I left some comments on the API design, but consider them non-blocking. API LGTM if LGT @Hixie.

@flar flar force-pushed the imagefiltered-widget branch from 38792c2 to a52f755 Compare December 20, 2019 23:51
@flar
Copy link
Contributor Author

flar commented Dec 20, 2019

The engine implementation for C++ has rolled into the framework repo with web stubs, and the web implementation that removes the stubs is staged in the engine roller (just waiting for the tree to go green to be rolled), so I am removing the WIP label.

This PR should be ready to go.

@flar flar force-pushed the imagefiltered-widget branch from a52f755 to 8ac22a9 Compare December 21, 2019 01:02
@Hixie
Copy link
Contributor

Hixie commented Dec 21, 2019

LGTM modulo comments

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit fcaf9c4 into flutter:master Dec 21, 2019
@flar flar deleted the imagefiltered-widget branch September 4, 2020 19:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImageFilter widget

6 participants