Added showCheckboxColumn parameter to DataTable and PaginatedDataTable#47552
Merged
Added showCheckboxColumn parameter to DataTable and PaginatedDataTable#47552
showCheckboxColumn parameter to DataTable and PaginatedDataTable#47552Conversation
fluttergithubbot
added
f: material design
Hixie
reviewed
Dec 20, 2019
Hixie
reviewed
Dec 20, 2019
Hixie
reviewed
Dec 20, 2019
Contributor
|
approach SGTM |
`showCheckboxColumn` will determine whether or not selectable rows in DateTable or PaginatedDataTable will contain a leading CheckBox.
bkonyi
force-pushed
the
data_table_checkboxes
branch
from
0269eb0 to
b239cdf
Compare
Contributor
Author
|
Not sure why I'm having some golden tests fail. @Piinks would you happen to know if I'm just holding something wrong? |
Contributor
|
Looks some new golden files landed and weren't triaged. Should be all good now. I've re-run the failed tasks. :) |
Contributor
Author
My hero! Thanks Kate :-) |
goderbauer
approved these changes
Jan 3, 2020
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM modulo minor comments
goderbauer
approved these changes
Jan 6, 2020
| home: Material(child: buildTable()), | ||
| )); | ||
|
|
||
| //print(find.byType(Checkbox).allCandidates.length); |
Co-Authored-By: Michael Goderbauer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
showCheckboxColumnproperty will determine whether or not selectable rows in DateTable or PaginatedDataTable will contain a leading CheckBox.showCheckboxColumn == true:
showCheckboxColumn == false:
Related Issues
N/A
Tests
I added the following tests:
DataTable control test - no checkboxesChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.