Roll to include Dart changes to timeline to fix devicelab.#47896
Merged
franciscojma86 merged 1 commit intoflutter:masterfrom Dec 27, 2019
Merged
Roll to include Dart changes to timeline to fix devicelab.#47896franciscojma86 merged 1 commit intoflutter:masterfrom
franciscojma86 merged 1 commit intoflutter:masterfrom
Conversation
Contributor
Author
|
Confirmed that tiles_scroll_perf_ios__timeline_summary fails due to "durations is empty" before this change and succeeds after... |
Contributor
|
Landing on red to fix the build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #47742 included changes to parse the timelines that are implemented in the Dart changes in this Engine commit. Manually rolling the engine version to unbreak the build.