EditableText should not update textinput style when the textinput is …#47904
Merged
chunhtai merged 3 commits intoflutter:masterfrom Jan 3, 2020
Merged
EditableText should not update textinput style when the textinput is …#47904chunhtai merged 3 commits intoflutter:masterfrom
chunhtai merged 3 commits intoflutter:masterfrom
Conversation
mdebbar
approved these changes
Dec 30, 2019
Contributor
mdebbar
left a comment
There was a problem hiding this comment.
LGTM. Thanks for improving this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…not attached
Description
EditableText didupdatewidget will attempt to update textinput style if the widget.style has changed.
The pr makes sure it only updates it when textinput is attached, otherwise does nothing.
Related Issues
Closes #40755
Tests
I added the following tests:
"can update style of previous activated EditableText"
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.