Skip to content

Avoid use of run-as#48

Merged
abarth merged 1 commit intoflutter:masterfrom
jeffallen:no-run-as
Nov 7, 2015
Merged

Avoid use of run-as#48
abarth merged 1 commit intoflutter:masterfrom
jeffallen:no-run-as

Conversation

@jeffallen
Copy link
Contributor

@jeffallen jeffallen commented Nov 7, 2015

Issue #1988 results from run-as not working on some phones,
because of Android issue 58373.

This change removes the need for run-as for running
"flutter start". It is still needed for tracing.

@jeffallen
Avoid use of run-as
c8c2d23 
Issue flutter#1988 results from run-as not working on some phones,
because of Android issue 58373.

This change removes the need for run-as for running
"flutter start". It is still needed for tracing.
@jeffallen
Copy link
Contributor Author

jeffallen commented Nov 7, 2015

Still not tested because I still don't know how to do it. I discovered "pub run bin/sky_tools.dart" but I can't run that from my flutter app source code directory.

@abarth
Copy link
Contributor

abarth commented Nov 7, 2015

Thanks for the patch.

You should be able to run the code using the bin/flutter script. That script makes a snapshot of the code, so you might need to remove the snapshot from the bin/cache directory when you make changes to the Dart code. (We're still smoothing out the dev workflow.)

@abarth
Copy link
Contributor

abarth commented Nov 7, 2015

LGTM

abarth added a commit that referenced this pull request Nov 7, 2015
@abarth
Merge pull request #48 from jeffallen/no-run-as
c9a79bf 
Avoid use of run-as
@abarth abarth merged commit c9a79bf into flutter:master Nov 7, 2015
@jeffallen jeffallen deleted the no-run-as branch November 7, 2015 18:49
@mpcomplete mpcomplete mentioned this pull request Apr 20, 2016
Closed
@mpcomplete mpcomplete mentioned this pull request Jun 17, 2016
Closed
@mikejurka mikejurka mentioned this pull request Jul 8, 2016
Closed
@jason-simmons jason-simmons mentioned this pull request Jul 21, 2016
Closed
@mswift42 mswift42 mentioned this pull request Nov 13, 2016
Closed
@gavindoughtie gavindoughtie mentioned this pull request Dec 2, 2016
Closed
@rantianhua rantianhua mentioned this pull request Jan 13, 2017
Closed
@Reagankm Reagankm mentioned this pull request Jan 19, 2017
Closed
@ppolasek ppolasek mentioned this pull request Feb 8, 2017
Closed
@skybrian skybrian mentioned this pull request Feb 16, 2017
Closed
@Reagankm Reagankm mentioned this pull request Feb 24, 2017
Closed
@collinjackson collinjackson mentioned this pull request May 19, 2017
Closed
@cdotstout cdotstout mentioned this pull request Jun 7, 2017
Closed
@BoaNeo BoaNeo mentioned this pull request Jul 4, 2017
Closed
@jamesgopinath jamesgopinath mentioned this pull request Aug 4, 2017
Closed
@apwilson apwilson mentioned this pull request Aug 10, 2017
Closed
@JFixby JFixby mentioned this pull request Sep 7, 2017
Closed
@DaveShuckerow DaveShuckerow mentioned this pull request Sep 18, 2017
Closed
@gavindoughtie gavindoughtie mentioned this pull request Sep 25, 2017
Closed
@arnold-nonstop arnold-nonstop mentioned this pull request Sep 29, 2017
Closed
@amirh amirh mentioned this pull request Oct 9, 2017
Closed
@PlanovskyJus PlanovskyJus mentioned this pull request Nov 3, 2017
Closed
@steele232 steele232 mentioned this pull request Nov 9, 2017
Closed
@issantech issantech mentioned this pull request Nov 23, 2020
Closed
@RobynKing88 RobynKing88 mentioned this pull request Dec 6, 2020
Closed
This was referenced Dec 11, 2020
Closed
Closed
@fnoceda fnoceda mentioned this pull request Dec 14, 2020
Closed
@sureace sureace mentioned this pull request Jan 13, 2021
Closed
@MobileAppGwt MobileAppGwt mentioned this pull request Jan 20, 2021
Closed
@staminna staminna mentioned this pull request Jan 22, 2021
Closed
@yannainghtun-mk yannainghtun-mk mentioned this pull request Jan 26, 2021
Closed
@1005274291 1005274291 mentioned this pull request Jan 26, 2021
Closed
@praneethpj praneethpj mentioned this pull request Jan 29, 2021
Closed
@sravanpabolu sravanpabolu mentioned this pull request Feb 11, 2021
Closed
@lianchengtong lianchengtong mentioned this pull request Feb 13, 2021
Closed
@PiechKevin PiechKevin mentioned this pull request Feb 14, 2021
Closed
@Marko1994 Marko1994 mentioned this pull request Mar 4, 2021
Closed
@lironzemingo lironzemingo mentioned this pull request Mar 11, 2021
Closed
@deCardenas deCardenas mentioned this pull request Apr 10, 2021
Closed
@bladeofgod bladeofgod mentioned this pull request Apr 14, 2021
Open
@sanjitsarkar sanjitsarkar mentioned this pull request Apr 24, 2021
Closed
@sauravgpt sauravgpt mentioned this pull request Apr 28, 2021
Closed
@naveedrehman90001 naveedrehman90001 mentioned this pull request May 6, 2021
Closed
@radensoft radensoft mentioned this pull request May 9, 2021
Closed
@sanjitsarkar sanjitsarkar mentioned this pull request May 13, 2021
Closed
@SlowGen SlowGen mentioned this pull request May 27, 2021
Closed
@Achudh Achudh mentioned this pull request Jun 4, 2021
Closed
@Dalimar95 Dalimar95 mentioned this pull request Jun 8, 2021
Closed
@akashgk akashgk mentioned this pull request Jun 18, 2021
Closed
@SamStrike0809 SamStrike0809 mentioned this pull request Jun 18, 2021
Closed
@94wogus 94wogus mentioned this pull request Jul 3, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffallen @abarth