Test hot reload targeting a Fuchsia device#48472
Merged
fluttergithubbot merged 5 commits intoflutter:masterfrom Jan 10, 2020
Merged
Test hot reload targeting a Fuchsia device#48472fluttergithubbot merged 5 commits intoflutter:masterfrom
fluttergithubbot merged 5 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
d: examples
blasten
force-pushed
the
fuchsia_attach_test
branch
from
7ff03e6 to
f53fdb9
Compare
blasten
force-pushed
the
fuchsia_attach_test
branch
from
f53fdb9 to
c8f86bc
Compare
blasten
force-pushed
the
fuchsia_attach_test
branch
from
c8f86bc to
c96d143
Compare
Author
|
@zanderso PTAL |
zanderso
reviewed
Jan 9, 2020
added 2 commits
January 9, 2020 14:17
zanderso
approved these changes
Jan 9, 2020
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
lgtm w/ fix of analyzer message in attach.dart
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests hot reload on a Fuchsia device.
I still need to filter out old logs from the
FuchsiaDevicelogger since it currently doesn't filter old logs. This doesn't affect the outcome of this test though.