Alter iOS template project to be CocoaPods enabled#4893
Alter iOS template project to be CocoaPods enabled#4893collinjackson merged 1 commit intoflutter:masterfrom
Conversation
There was a problem hiding this comment.
Should these Debug.xcconfig and Release.xcconfig files be in the Flutter directory? Where are they in a normal cocoapods project?
There was a problem hiding this comment.
These files are normally in the Pods directory, which I need to check in anyway since we don't want to require people to install CocoaPods to use flutter create. I've added it to this pull request.
|
LGTM but @chinmaygarde or @tvolkert should review as well. |
collinjackson
force-pushed
the
ios_enable_cocoapods
branch
from
16f9f9d to
dd2f933
Compare
|
@abarth, I figured out how to make flutter run deal with workspaces, will land that as a separate PR (and also remove the dependency on FlutterAppDelegate) |
|
Great! |
collinjackson
force-pushed
the
ios_enable_cocoapods
branch
from
dd2f933 to
f6f3860
Compare
|
@chinmaygarde can you take a look? |
|
|
||
| target 'Runner' do | ||
| # Uncomment this line if you're using Swift or would like to use dynamic frameworks | ||
| # use_frameworks! |
There was a problem hiding this comment.
I am not sure I understand what exactly this does but the Flutter engine is itself a framework.
There was a problem hiding this comment.
This comment is in the default Podfile you get if you say "pod init" so I've left it. If we ever turn Flutter into a Pod we'll want to revisit
|
lgtm. Though I am not too familiar with CocoaPods myself. |
collinjackson
force-pushed
the
ios_enable_cocoapods
branch
from
f6f3860 to
613ad60
Compare
|
Not sure if you plan to land this? We can also re-do this once we're more able to focus on external development. |
|
Let's land it. I am happy to maintain a few external CocoaPod plugins and I'm interested in feedback from external developers on whether this is useful. |
|
@collinjackson, do end users need to have cocoapods installed now? Or is this change to the template self-contained? |
|
It should be self-contained. The goal is that users do not need to have cocoapods installed, unless they want to add a cocoapod to their project. If this isn't the case, it's a bug that should be fixed. |
|
I believe they're all the same bug and all are fixed. I think the lesson here is we need some process that ensures that we push to alpha when critical bugs are fixed, so people don't keep reopening them. Or alternatively, update the setup instructions to point to master. |
|
See also #5433 would teach Travis to ensures that new projects build successfully |
5 participants
No description provided.