Selection menu not showing when selection is 0,0#49000
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Jan 17, 2020
Merged
Selection menu not showing when selection is 0,0#49000fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
@gspencergoog I see you added a similar check in the |
446e6fb to
9fb70ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Before this PR, if you set a TextField's controller with a selection of 0,0, then the TextField wouldn't show the selection menu before any text was entered.
The problem is that when the user focuses the field, RenderEditable tries to set the selection to 0,0, but it sees that it already is 0,0 and thinks nothing has changed. EditableText is not informed that anything happened, and the selection menu is not created. Usually, selection would be -1,-1 and this would work fine.
This PR considers this situation to be a selection change, so the field will be focused and the selection menu can be shown.
Related Issues
Closes #37798
Tests