[flutter_tools] initialize frontend server with build#49405
Merged
jonahwilliams merged 11 commits intoflutter:masterfrom Feb 24, 2020
Merged
[flutter_tools] initialize frontend server with build#49405jonahwilliams merged 11 commits intoflutter:masterfrom
jonahwilliams merged 11 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
tool
Contributor
Author
|
This also makes the fast-start workflow less bad, yay! |
christopherfujino
approved these changes
Feb 18, 2020
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
lgtm, with one spelling nit. cool!
| final List<Future<bool>> startupTasks = <Future<bool>>[]; | ||
| for (final FlutterDevice device in flutterDevices) { | ||
| final int result = await device.runHot( | ||
| // Here we initialize the frontend_server conccurently with the gradle |
Contributor
There was a problem hiding this comment.
nit. conccurently -> concurrently
Contributor
Author
|
Ahh, it started timing out again. Looks like I didn't hit all of the race conditions in the test |
Contributor
Author
|
Removing unnecessary synchronization for the second tick seems to have removed the flakiness |
Contributor
|
looks gooder |
jonahwilliams
pushed a commit
that referenced
this pull request
Feb 26, 2020
This reverts commit 59cc3cd.
jonahwilliams
pushed a commit
that referenced
this pull request
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initialize the frontend_server while performing the platform initialization step (xcode/gradle). Massive performance improvement on startup. Also fixes flakiness in integration tests triggered by changing elapsed time.
Fixes #40388
Fixes #49865
Fixes #43464 (at least I think...)