update flutter run --devfs#4942
Merged
devoncarew merged 3 commits intoflutter:masterfrom Jul 18, 2016
Merged
Conversation
| Future<CreateDevFSResponse> createDevFS(String fsName) { | ||
| return sendRequest( | ||
| '_createDevFS', <String, dynamic> { 'fsName': fsName } | ||
| ).then((Response response) => new CreateDevFSResponse(response.response)); |
Contributor
There was a problem hiding this comment.
I think this is a good place to take advantage of async/await
Contributor
|
I'm afraid of leaking timed out HTTP requests. What level of robustness are we shooting for? LGTM otherwise. |
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Apr 5, 2018
Includes: * Add armv7 support to create_ios_framework script (flutter#4942) * Roll Dart to version 09e1766e6caa537e1271fbce04ebcbf8212b6569 (flutter#4941)
cbracken
added a commit
that referenced
this pull request
Apr 6, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * Add armv7 support to create_ios_framework script (flutter#4942) * Roll Dart to version 09e1766e6caa537e1271fbce04ebcbf8212b6569 (flutter#4941)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter run --devfsto handle changes to the_createDevFSobservatory call@yjbanov