[flutter_tools] Migrate xcode_backend.sh to flutter assemble#49842
[flutter_tools] Migrate xcode_backend.sh to flutter assemble#49842jonahwilliams merged 8 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
tool
|
This is exciting. |
| -dBuildMode=${build_mode} \ | ||
| -dIosArchs="${ARCHS}" \ | ||
| -dTrackWidgetCreation="${track_widget_creation_flag}" \ | ||
| -dEnableBitcode="${bitcode_flag}" \ |
There was a problem hiding this comment.
Should this be either true or false? Right now it can end up as an empty string.
| -dTargetFile="${target_path}" \ | ||
| -dBuildMode=${build_mode} \ | ||
| -dIosArchs="${ARCHS}" \ | ||
| -dTrackWidgetCreation="${track_widget_creation_flag}" \ |
There was a problem hiding this comment.
Also on this one. Right now this can either come out as true or an empty string.
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM
I'll be able to integrate this into the font subset PR when it lands and add support for iOS there. Or just do it as a separate PR since that one is getting large.
|
Separate PR is probably ideal, should be a quick to review PR |
| bitcode_flag="--bitcode" | ||
| fi | ||
|
|
||
| # TODO(jonahwilliams): move engine copying to build system. |
There was a problem hiding this comment.
See copyEngineArtifactToProject in project.dart.
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Checked out the branch, the following seems to work:
- Run on a device in Debug, Profile, and Release
- Run on a simulator in Debug
- Archive with bitcode enabled
- Archive with bitcode disabled
flutter build ios-framework
LGTM
|
This pull request is not suitable for automatic merging in its current state.
|
jonahwilliams
added
waiting for customer response
5 participants
Description
Updates xcode_backend.sh to use (mostly) assemble APIs. This almost completes the migration, though I still need to move the asset unpack step - this is slightly more complicated due to the module format.
Should have no new external behavior, but does allow us to more easily wire up new features like font-subset, dart-defines, and obfuscation (which was never implemented for iOS?)
FYI @dnfield
Fixes #32925