Skip to content

Revert "[flutter_tools] Migrate xcode_backend.sh to flutter assemble"#50151

Merged
jonahwilliams merged 1 commit intomasterfrom
revert-49842-full_assemble
Feb 4, 2020
Merged

Revert "[flutter_tools] Migrate xcode_backend.sh to flutter assemble"#50151
jonahwilliams merged 1 commit intomasterfrom
revert-49842-full_assemble

Conversation

@jonahwilliams
Copy link
Contributor

Reverts #49842

This is breaking several devicelab tests with:

/Users/jonahwilliams/Documents/flutter/bin/cache/dart-sdk/bin/dart /Users/jonahwilliams/Documents/flutter/bin/cache/artifacts/engine/darwin-x64/frontend_server.dart.snapshot --sdk-root /Users/jonahwilliams/Documents/flutter/bin/cache/artifacts/engine/common/flutter_patched_sdk/ --target=flutter -Ddart.developer.causal_async_stacks=true -Ddart.vm.profile=false -Ddart.vm.product=false --bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --no-link-platform --packages .packages.generated --output-dill /Users/jonahwilliams/Documents/flutter/dev/integration_tests/codegen/.dart_tool/flutter_build/9d5795a2b07f1683948ad6bf7dbeeae0/app.dill --filesystem-root /Users/jonahwilliams/Documents/flutter/dev/integration_tests/codegen/.dart_tool/build/generated/codegen/lib/ --filesystem-root /Users/jonahwilliams/Documents/flutter/dev/integration_tests/codegen/lib/ --filesystem-scheme org-dartlang-app package:codegen/main.dart
[codegen_integration_mac] [STDOUT] stdout:                [+7165 ms] kernel_snapshot: Complete
[codegen_integration_mac] [STDOUT] stdout:                [ +865 ms] Persisting file store
[codegen_integration_mac] [STDOUT] stdout:                [   +2 ms] Done persisting file store
[codegen_integration_mac] [STDOUT] stdout:                [   +1 ms] Target debug_universal_framework failed: ProcessException: Process exited abnormally:
[codegen_integration_mac] [STDOUT] stdout:                           fatal error: /Users/jonahwilliams/Downloads/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: can't create temporary output file: /Users/jonahwilliams/Documents/flutter/dev/integration_tests/codegen/.dart_tool/flutter_build/9d5795a2b07f1683948ad6bf7dbeeae0/iphone_framework.lipo (No such file or directory)
[codegen_integration_mac] [STDOUT] stdout:                           clang: error: lipo command failed with exit code 1 (use -v to see invocation)
[codegen_integration_mac] [STDOUT] stdout:                             Command: xcrun clang -x c -arch armv7 -arch arm64 /var/folders/sq/vd7vtp0j60ld19wt58vg7n5c00c4f_/T/flutter_tools_stub_source.LdwymN/debug_app.cc -dynamiclib -fembed-bitcode-marker -Xlinker -rpath -Xlinker @executable_path/Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -install_name @rpath/App.framework/App -isysroot /Users/jonahwilliams/Downloads/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.1.sdk -o /Users/jonahwilliams/Documents/flutter/dev/integration_tests/codegen/.dart_tool/flutter_build/9d5795a2b07f1683948ad6bf7dbeeae0/iphone_framework
[codegen_integration_mac] [STDOUT] stdout:                [   +1 ms] "flutter assemble" took 30,448ms.
[codegen_integration_mac] [STDOUT] stdout:                build failed.
[codegen_integration_mac] [STDOUT] stdout: 
[codegen_integration_mac] [STDOUT] stdout:                #0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
[codegen_integration_mac] [STDOUT] stdout:                #1      AssembleCommand.runCommand (package:flutter_tools/src/commands/assemble.dart:193:7)
[codegen_integration_mac] [STDOUT] stdout:                <asynchronous suspension>
[codegen_integration_mac] [STDOUT] stdout:                #2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:639:18)
[codegen_integration_mac] [STDOUT] stdout:                <asynchronous suspension>

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 4, 2020
@jonahwilliams
Copy link
Contributor Author

TBR @jmagman landing on red to fix build.

@jonahwilliams jonahwilliams merged commit 52d5744 into master Feb 4, 2020
@jonahwilliams jonahwilliams deleted the revert-49842-full_assemble branch February 4, 2020 23:03
@dnfield
Copy link
Contributor

dnfield commented Feb 5, 2020

LGTM.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants