catch release builds pre-submit#50515
Merged
christopherfujino merged 1 commit intoflutter:masterfrom Feb 13, 2020
Merged
Conversation
christopherfujino
force-pushed
the
further-codesign-test-improvements
branch
from
3ad492f to
77493ce
Compare
jmagman
approved these changes
Feb 11, 2020
| - name: verify_binaries_codesigned-macos # macos-only | ||
| # TODO(fujino): remove this `only_if` after https://github.com/flutter/flutter/issues/44372 | ||
| only_if: "$CIRRUS_BRANCH == 'dev' || $CIRRUS_BRANCH == 'beta' || $CIRRUS_BRANCH == 'stable' || $CIRRUS_BRANCH =~ '.*hotfix.*'" | ||
| only_if: "$CIRRUS_BASE_BRANCH != 'master'" |
Contributor
Author
|
This ran on post-submit, not sure why. Until I do, I will revert. |
christopherfujino
added a commit
that referenced
this pull request
Feb 13, 2020
This reverts commit 7b7bd11.
jmagman
pushed a commit
that referenced
this pull request
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, this test only runs post-submit for release and hotfix branches. This change will make it run pre & post for any PR that isn't merging into master.
Related Issues
Fixes #50384
Tests
This causes an existing test to run in more situations.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].