Skip to content

Prevent Windows & Linux Cirrus cache from being re-downloaded#50527

Closed
jmagman wants to merge 3 commits intoflutter:masterfrom
jmagman:pub-cache
Closed

Prevent Windows & Linux Cirrus cache from being re-downloaded#50527
jmagman wants to merge 3 commits intoflutter:masterfrom
jmagman:pub-cache

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 11, 2020

Description

  1. Include the stamp files and Dart SDK in Cirrus cache to prevent full re-download.
  2. git clean -xffd --exclude=bin\cache\ wasn't working on Windows:
C:\Windows\Temp\flutter sdk>call git clean -xffd --exclude=bin\cache\ 
Removing bin/cache/
  1. Windows and Linux version of Turn back on macOS shard Cirrus caching #50496.
  2. Add population scripts to caches.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. work in progress; do not review team-infra Owned by Infrastructure team labels Feb 11, 2020
@jmagman jmagman self-assigned this Feb 11, 2020
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 11, 2020
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 11, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jmagman
jmagman commented Feb 11, 2020
View reviewed changes
.cirrus.yml Outdated
Copy link
Member Author

@jmagman jmagman Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked, guess git wanted forward slashes!

christopherfujino
christopherfujino approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman
Copy link
Member Author

jmagman commented Feb 11, 2020

Looks like flutter_tools.snapshot and flutter_tools.stamp need to be removed before upload, the cache is getting invalidated.

SHA for /tmp/flutter sdk/bin/cache is 'bb5fd511f0bde9ae2ffa9ec26c26b718fde3cce7663fe3c72ae97570cd10e560'
Cache all_flutter has changed!
List of changes for /tmp/flutter sdk/bin/cache:
modified: flutter_tools.snapshot
modified: flutter_tools.stamp
all_flutter cache size is 822Mb.
Uploading cache all_flutter...

@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 11, 2020

Still LGTM

jmagman
jmagman commented Feb 12, 2020
View reviewed changes
.cirrus.yml
populate_script:
- git fetch origin
- git fetch origin master # To set FETCH_HEAD, so that "git merge-base" works.
- flutter precache --android --ios --web
Copy link
Member Author

@jmagman jmagman Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--android and --ios are true by default but the precache flags are confusing, so don't make it look like we're just caching web.

@christopherfujino
Copy link
Contributor

christopherfujino commented Feb 12, 2020

Still LGTM.

@jmagman
Copy link
Member Author

jmagman commented Feb 12, 2020

Abandoning until cirruslabs/cirrus-ci-docs#566 is resolved.

@jmagman jmagman closed this Feb 12, 2020
@jmagman jmagman mentioned this pull request Feb 12, 2020
Merged
10 tasks
@jmagman jmagman deleted the pub-cache branch July 18, 2020 02:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmagman @fluttergithubbot @christopherfujino @googlebot @zanderso