[flutter_tools] Disable analytics for more bots#50579
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Feb 11, 2020
zanderso:detect-azure
Merged
[flutter_tools] Disable analytics for more bots#50579fluttergithubbot merged 1 commit intoflutter:masterfrom zanderso:detect-azure
fluttergithubbot merged 1 commit intoflutter:masterfrom
zanderso:detect-azure
Conversation
zanderso
added
tool
tvolkert
reviewed
Feb 11, 2020
Contributor
There was a problem hiding this comment.
Make this public and @visibleForTesting so you can unit test it?
tvolkert
approved these changes
Feb 11, 2020
zanderso
added a commit
that referenced
this pull request
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to teach the
BotDetectorto recognize when the tool is running in the cloud on Azure. This is accomplished by querying the Azure Instance Metadata Service via the non-routable IP address169.254.169.254. If we don't get a socket connection to that address within one second, this PR assumes that the tool is not on Azure.Refactorings to support the bot detector now being async are also included.
Related Issues
#4709
Tests
I added the following tests:
Test in
bot_detector_test.dart.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].