Merged
Conversation
This reverts commit e4fbb1a.
fluttergithubbot
added
the
c: contributor-productivity
Contributor
|
LGTM. Landing on red to unred the tree. Not sure why this is timing out on devicelab :\ |
Contributor
|
@dnfield : maybe try to split your PR into 2 PRs, one for macos, and one for the rest, to see which one breaks the device lab? |
Contributor
|
@liyuqian it wasn't the macos part - that has no impact on the devicelab. The test itself is failing to connect to the vm service. |
Contributor
|
Great. That means we can at least merge a 1000-line change that adds |
Contributor
|
I'll open a new PR to land macos separately. I've started a reland PR here: #50987 which has passed all tests and just makes the new test flaky for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #50851
This is broken in the devicelab.