add macos project to macrobenchmarks#50999
Conversation
fluttergithubbot
added
the
c: contributor-productivity
|
I wonder why the original PR (#50851) has |
|
Ahh good catch, I'll fix that. I added |
|
I think this is right now. |
liyuqian
left a comment
liyuqian
left a comment
There was a problem hiding this comment.
RSLGTM. Defer the final LGTM to the desktop experts.
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with two small things
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
This file is a mistake that I didn't notice was added to the template. Someone just caught this and sent a PR recently that fixed the template, but this file should be removed here.
| PRODUCT_NAME = macrobenchmarks | ||
|
|
||
| // The application's bundle identifier | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.example.macrobenchmarks |
There was a problem hiding this comment.
Do we use junk bundle ID and copyright in the iOS app? If not, these should be fixed up.
There was a problem hiding this comment.
Yes - these values match the iOS versions.
|
This pull request is not suitable for automatic merging in its current state.
|
5 participants
Adds a macos project to macrobenchmarks for local testing. We do not yet have any benchmarks for this.
/cc @liyuqian @stuartmorgan