[web] Smoke tests for web engine#51003
Conversation
fluttergithubbot
added
d: examples
nturgut
force-pushed
the
smoke_test_fw
branch
from
6dcea7f to
8c4408f
Compare
|
Waiting for another PR to land before merging this test. |
.cirrus.yml
Outdated
There was a problem hiding this comment.
Should we reuse the web_integration_tests shard?
There was a problem hiding this comment.
It is very different as the content goes. Especially with the template. May be I am missing something. What is the advantage if we use it? We should also change/remove the template from that shard then.
There was a problem hiding this comment.
A smoke test is an integration test. It's just a simple integration test. So I thought it belonged in the integration test shard. We also probably don't want too many shards as they all run simultaneously and occupy machines. I imagine eventually we'll have a hundred integration tests, and we'll shard them into N shards as we see fit, similarly to what we do with widget tests. This way we don't have hand-maintained specialized shards.
… app. Clean flutter run command from cirrus.yml
nturgut
force-pushed
the
smoke_test_fw
branch
from
d704d03 to
2a49d7e
Compare
nturgut
added
waiting for tree to go green
and removed
waiting for PR to land (fixed)
| import 'package:flutter/widgets.dart'; | ||
|
|
||
| void main() => runApp(const Center(child: Text('Hello, world!', textDirection: TextDirection.ltr))); | ||
| void main() => |
There was a problem hiding this comment.
Could you open a new PR to revert this change?
There was a problem hiding this comment.
It adds a key to the Text widget, which is needed by the test.
There was a problem hiding this comment.
Why are we reverting the change? The test are passing. I checked the smoke test after the PR went in. It always passed. Build was also green after my change according to the dashboard.
5 participants
Description
We would like to add a simple smoke test which uses Flutter web engine and a Flutter app.
Steps before merging the PR:
Then we can add a task that looks like this to Cirrus:
dart dev/webdriver_test.dart &
flutter drive --target=test_driver/scroll_perf_web.dart -d web-server --release --browser-name=chrome
Related Issues
Tests
This PR only includes only test code.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.