[flutter_tools] Reland initialize frontend_sever with build#51477
Merged
fluttergithubbot merged 11 commits intoflutter:masterfrom Feb 26, 2020
Merged
[flutter_tools] Reland initialize frontend_sever with build#51477fluttergithubbot merged 11 commits intoflutter:masterfrom
fluttergithubbot merged 11 commits intoflutter:masterfrom
Conversation
added 11 commits
January 23, 2020 17:38
fluttergithubbot
added
the
tool
zanderso
approved these changes
Feb 26, 2020
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
lgtm if this wasn't the perf issue.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initialize the frontend_server while performing the platform initialization step (xcode/gradle). Massive performance improvement on startup. Also fixes flakiness in integration tests triggered by changing elapsed time.
Fixes #40388
Fixes #49865
Fixes #43464 (at least I think...)
Edit:
Reverted in 421056e to verify performance regression