[flutter_tools] support run -d chrome test scripts#51658
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Feb 28, 2020
Merged
[flutter_tools] support run -d chrome test scripts#51658fluttergithubbot merged 3 commits intoflutter:masterfrom
fluttergithubbot merged 3 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
tool
fluttergithubbot
added
the
c: contributor-productivity
yjbanov
reviewed
Feb 28, 2020
| message = '--- TEST FAILED ---'; | ||
| } | ||
| print(message); | ||
| html.HttpRequest.request( |
Contributor
There was a problem hiding this comment.
Since you don't have a specialized localhost server that understands this protocol, this is not needed. I only needed this in the other test because for release and profile mode I didn't (couldn't) use flutter run.
Contributor
Author
There was a problem hiding this comment.
Ahh, perfect!
yjbanov
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #49838
Allow debug mode web applications to run test scripts and other files not under
lib/. Adds an integration test for this, as well as for conditional imports.