Write FLUTTER_BUILD_MODE when using a local engine#51687
Merged
dnfield merged 2 commits intoflutter:masterfrom Mar 4, 2020
Merged
Write FLUTTER_BUILD_MODE when using a local engine#51687dnfield merged 2 commits intoflutter:masterfrom
dnfield merged 2 commits intoflutter:masterfrom
Conversation
9d22d4d to
221f8f1
Compare
dnfield
pushed a commit
that referenced
this pull request
Mar 4, 2020
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Mar 5, 2020
…lutter#51687)" (flutter#51943)" This reverts commit a5bd678.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Today, the flutter build mode is driven by the $CONFIGURATION from Xcode. This is easy to mess up if you're using a local engine, and the error message in such a case isn't helpful.
This change writes the FLUTTER_BUILD_MODE flag for the engine you're using. We can't use the ambient build mode because it doesn't necessarily correspond to the engine build type.
Related Issues
Fixes #51673
Tests
I added the following tests:
Test that we write the right flags into Generated.xcconfig and the other new file.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.