Custom onPressed behavior for CloseButton widget#51925
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Mar 5, 2020
Merged
Custom onPressed behavior for CloseButton widget#51925fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
@HansMuller Could you please help review it? Thanks. |
shihaohong
reviewed
Mar 4, 2020
shihaohong
reviewed
Mar 4, 2020
shihaohong
approved these changes
Mar 5, 2020
Contributor
shihaohong
left a comment
There was a problem hiding this comment.
LGTM. Thanks for improving the other test as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In our application we want to display a close icon in AppBar with customized behavior.
backButton has onPressed parameter in initializer to enable override of default navigator pop behavior. closeButton should also be able to set it. This PR proposes a fix to it.
Related Issues
Fixes #51924
Tests
I added the following tests:
CloseButton onPressed overrides default pop behavior
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.