Step 2: SnackBarBehavior.floating offset fix by default#52136
Step 2: SnackBarBehavior.floating offset fix by default#52136shihaohong wants to merge 3 commits intoflutter:masterfrom shihaohong:snackbar-fix
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is currently still being blocked by fixing internal tests. Since there are a ton of golden tests with the SnackBar, this will likely be a longer migration process and I haven't had the time to go through these updates. I'll close the PR for now since I don't have the bandwidth to tackle that migration. When I do, I'll reopen the PR! |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Closing in favor of #54985 because of CI failure unrelated to PR |
Description
Continuation from #50597, applying the offset fix by default.
Migration guide
Scaffold.shouldSnackBarIgnoreFABRecttotrueafter this PR is merged.a) Fix all golden tests to expect the new change.
b) Fix any widget tests that expect the SnackBar to appear higher than it should. The difference should simply be the size of the floating action button's rect.
Scaffold.shouldSnackBarIgnoreFABRectis set to true by default (in a subsequent PR), remove the parameter from all instances ofScaffold.Related Issues
Addresses #47202
Addresses #43716
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.