Skip to content

Fetch tags for version command#52212

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
dnfield:version_fix
Mar 14, 2020
Merged

Fetch tags for version command#52212
fluttergithubbot merged 1 commit intoflutter:masterfrom
dnfield:version_fix

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 8, 2020

Description

Fetch upstream tags as part of the version command.

Related Issues

Fixes reported issues in #14230
See also #52062

Tests

I added the following tests:

Assert that flutter version calls the fetchAndUpdateTags on the global flutterVersion.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@dnfield dnfield requested review from jmagman and jonahwilliams March 8, 2020 22:55
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 8, 2020
jonahwilliams
jonahwilliams reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See L70:

We're recommending that users not invoke the version command, and personally I'd like to remove it if possible in a future release

jmagman
jmagman approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@jonahwilliams this command probably isn't going away any time soon...

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Mar 13, 2020

FWIW It isn't on part of the main upgrade/downgrade workflow and we have no obligation to maintain it otherwise.

@dnfield
Copy link
Contributor Author

dnfield commented Mar 13, 2020

This should at least be an incremental improvement that's fairly easy to apply. The command definitely still has issues and needs more work or to be removed (and probably clearly deprecated first).

I think we could probably deprecate it as long as we had some good story about what to use instead.

@fluttergithubbot fluttergithubbot merged commit 98cf018 into flutter:master Mar 14, 2020
@tvolkert tvolkert mentioned this pull request Mar 26, 2020
Closed
@lock
Copy link

lock bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dnfield @jonahwilliams @jmagman @googlebot @fluttergithubbot