Apply fetch tag logic to upgrade command, build ios framework.#52250
Apply fetch tag logic to upgrade command, build ios framework.#52250dnfield wants to merge 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
| void produceFlutterPodspec(BuildMode mode, Directory modeDirectory, { bool force = false }) { | ||
| final Status status = globals.logger.startProgress(' ├─Creating Flutter.podspec...', timeout: timeoutConfiguration.fastOperation); | ||
| try { | ||
| _flutterVersion.fetchTagsAndUpdate(); |
There was a problem hiding this comment.
Is there anywhere we request gitTagVersion where we wouldn't want to fetch the tags first?
There was a problem hiding this comment.
Yes. We get the flutter version for basically every command, which does this work. If we do this for every anayzer or build invocation it is a measurable performance hit.
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Why does build-ios-framework need this?
For that matter, why does anyone that isn't using a weird developer workflow on master need this?
|
|
There are a lot of ways to fail to pull down tags |
|
Presumably users on the normal upgrade flow would already have the right tags to know what version they're on? |
|
I think I'm misunderstanding the purpose of this change. Can we chat about the offline (online) for a few minutes? |
|
before trying to land this, I'll try to fix the tag logic so it only runs on branches other than dev/beta/stable |
|
Hi @dnfield what's the status of this PR? |
|
Now that the fetch tag logic has been changed to only run on master, we can probably close this. |
|
SGTM |
6 participants
Applies logic from #52141 to
upgradeandbuild ios-framework. Both of these depend on tags being correct to run properly.This is expected to not regress benchmarks, since
analyze,run, and other build commands that do not depend on tags are not affected./cc @zanderso @jonahwilliams @jmagman