Skip to content

[flutter_tools] don't force service worker cache files to be absolute#52606

Merged
jonahwilliams merged 5 commits intoflutter:masterfrom
jonahwilliams:base_url_canvas_kit
Mar 17, 2020
Merged

[flutter_tools] don't force service worker cache files to be absolute#52606
jonahwilliams merged 5 commits intoflutter:masterfrom
jonahwilliams:base_url_canvas_kit

Conversation

@jonahwilliams
Copy link
Contributor

Description

Along with the change to make index.html paths relative, this allows flutter for web applications to be hosted anywhere. Also updates index.html in flutter gallery

Fixes #50580

@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 14, 2020
@jonahwilliams jonahwilliams merged commit a7011c4 into flutter:master Mar 17, 2020
@jonahwilliams jonahwilliams deleted the base_url_canvas_kit branch March 17, 2020 17:17
@jlubeck
Copy link
Contributor

jlubeck commented Mar 19, 2020

I take it this didn't make it into the beta channel that got pushed 2 days ago right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_tools][web]: tools and generated content assume app is hosted in the root of the web host

5 participants