Increase xcdevice timeout to 2 seconds#53184
Conversation
|
I remember there was discussion around this, but what is the default again? @jmagman |
I don't think the default is documented, but without a timeout it returns as soon as it discovers all the tethered devices and simulators, I believe. So on my machine it's <0.5 seconds. For some reason on some machines it takes longer than a second (at least I'm guessing that's what's happening) so this PR is to let |
|
I'm getting ~6 seconds running |
|
Analysis is failing with:
|
Hmm, maybe I need to up it to 2 seconds then. I've seen missing plugged in devices quite a few times in the devicelab today. |
|
This makes me sad. |
Description
xcdevicewas returning before it found all tethered devices on some machines, flakily. Up the timeout to 2 seconds. :-(Related Issues
Fixes #53182
Tests
Updated xcode_tests with new behavior.
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change