Fix diagnostics crash in profile mode#53878
Merged
ferhatb merged 3 commits intoflutter:masterfrom Apr 3, 2020
Merged
Conversation
fluttergithubbot
added
the
framework
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
approved these changes
Apr 2, 2020
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
Apr 6, 2020
* Prevent diagnostics crash in profile mode * Prevent diagnostics crash in profile mode
pcsosinski
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Support old and new git release tag formats (#53715) * Improve downgrade-upgrade integration test (#53775) * Fix diagnostics crash in profile mode (#53878) * Prevent diagnostics crash in profile mode * Prevent diagnostics crash in profile mode Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Ferhat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When DiagnosticsNode is used in profile mode it crashed during FlutterErrorDetails construction.
This PR guards against null build.properties and emptyBodyDescription.
When web users encounter an exception in release builds, they use --profile to diagnose the issue. Without this fix they can't see the correct exception/stack trace.
Related Issues
#53487
Fixes: #54108
Tests
I added the following tests:
The test requires end to end test running in profile mode. PR for engine E2E test: flutter/engine#17492
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].