[flutter_tools] Use gzip level 1 for devfs transfer compression#54123
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Apr 8, 2020
zanderso:compression-level
Merged
[flutter_tools] Use gzip level 1 for devfs transfer compression#54123fluttergithubbot merged 1 commit intoflutter:masterfrom zanderso:compression-level
fluttergithubbot merged 1 commit intoflutter:masterfrom
zanderso:compression-level
Conversation
zanderso
added
tool
Contributor
There was a problem hiding this comment.
Thinking about how this API will evolve in a world without globals. Either:
- every
DevFSContentneeds a reference toOperatingSystemUtils contentsAsCompressedStreamaccepts anOperatingSystemUtilsor aStream<List<int>> Function(Stream<List<int>>)torn off from one.
The latter case sounds more appealing to me, since it simplifies the construction of the DevFSContent classes and reduces the dependencies. In that case, instead of mocking the OperatingSystemUtils for the current test, you might need to do something different.
zanderso
added
waiting for tree to go green
and removed
work in progress; do not review
labels
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is #52666, but refactored to allow tests to be written.
Tests
I added the following tests:
Tests added to devfs_test.dart and os_test.dart.
Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].