Adding vscode path installed though snap#54415
Adding vscode path installed though snap#54415jeanluc243 wants to merge 3 commits intoflutter:masterfrom
Conversation
Adding vscode path installed though snap
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@jeanluc243 If you'd like to continue with this PR, please sign the CLA, and see our CONTRIBUTING.md. Thanks! |
|
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@jeanluc243 the change seems reasonable, but it looks like git is a bit confused. I would recommend following the contributing guide in CONTRIBUTING.md, specifically setting up a separate flutter checkout for contributing and branching off of upstream/aster |
|
@jeanluc243 unfortunately because of a change I made and landed upstream, CI won't pass for this PR. The easiest way to fix this would be to fetch the latest upstream master locally, create a new branch off of the tip of master, and then re-create your changes (as it's only a few lines that shouldn't be difficult). This change will also require tests. Feel free to ping me on your new PR if you need help writing tests. |
|
@jeanluc243 Since the PR has to be recreated following @christopherfujino's, I'm going to close this one. Thanks! |
Description
Adding path to VScode directory installed through snap on Linux
Related Issues
VS Code installed via Snap does not appear in flutter doctor #54358