Revert "[devicelab] Do not wait for connections after process has exited"#54618
Merged
jonahwilliams merged 1 commit intomasterfrom Apr 13, 2020
Merged
Revert "[devicelab] Do not wait for connections after process has exited"#54618jonahwilliams merged 1 commit intomasterfrom
jonahwilliams merged 1 commit intomasterfrom
Conversation
This reverts commit 283ec9e.
yjbanov
approved these changes
Apr 13, 2020
Contributor
|
Darn. The flake was exactly what I was aiming to fix. |
Contributor
|
@jonahwilliams where did you see it fail? Cirrus? LUCI? |
Contributor
Author
|
Landing on red since this is a revert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #54497
This change has led to a new flake: