force upgraded package dependencies#54787
Merged
jmagman merged 1 commit intoflutter:masterfrom Apr 15, 2020
Merged
Conversation
9 tasks
Member
|
@jonahwilliams this LGTM do you know any reason why this would be an issue? I think you put out the last few PRs to run upgrade-packages. |
Contributor
|
Nope, all good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently PRs adding or modifying a pubspec.yaml file face the issue of failing the analyze-linux check without executing
flutter upgrade-packages --force-upgradefirst. As this changes a lot of files throughout the repository, a separate PR for the upgrade seems appropriate.This PR is the state of repository after executing
flutter upgrade-packages --force-upgrade. The only upgraded package is the path package, which recently published a new version (1.7.0).Related Issues
#51126 contains a new integration test requiring a package upgrade to pass the analyze-linux check.
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].