Step 2: SnackBarBehavior.floating offset fix by default#54985
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Apr 16, 2020
shihaohong:snackbar-fix-attempt-2
Merged
Step 2: SnackBarBehavior.floating offset fix by default#54985fluttergithubbot merged 1 commit intoflutter:masterfrom shihaohong:snackbar-fix-attempt-2
fluttergithubbot merged 1 commit intoflutter:masterfrom
shihaohong:snackbar-fix-attempt-2
Conversation
11 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Re-attempt of #52136 due to CI failures unrelated to the PR.
Continuation from #50597, applying the offset fix by default. The PR that follows this will remove the flag altogether, making the fix a default setting and removing the previous, incorrect offset.
Migration guide
Scaffold.shouldSnackBarIgnoreFABRecttotrueafter this PR is merged.a) Fix all golden tests to expect the new change.
b) Fix any widget tests that expect the SnackBar to appear higher than it should. The difference should simply be the size of the floating action button's rect.
Scaffold.shouldSnackBarIgnoreFABRectis set to true by default (in a subsequent PR), remove the parameter from all instances ofScaffold.Related Issues
Addresses #47202
Addresses #43716
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.