Skip to content

manual engine roll (4bcfae82c7c1 -> 0c35a3417)#55891

Merged
christopherfujino merged 1 commit intoflutter:masterfrom
chris-forks:manual-engine-roll
Apr 28, 2020
Merged

manual engine roll (4bcfae82c7c1 -> 0c35a3417)#55891
christopherfujino merged 1 commit intoflutter:masterfrom
chris-forks:manual-engine-roll

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Apr 28, 2020

The autoroller is trying to roll based off of an old framework master commit which is before the new flutter release version tag. Thus, the tool cannot get a prior valid release tag, and parses the version as 0.0.0-unknown, causing flutter_tools unit tests to fail. This manual roll based off of latest master should pass. Whether or not it unblocks the autoroller is depends on if the autoroller picks a newer framework commit to base its next roll off of.

git log 4bcfae8..0c35a34 --first-parent --oneline
2020-04-28 [email protected] Roll src/third_party/skia f5132a05c893..4baa7326ccfb (1 commits) (flutter/engine#18003)
2020-04-28 [email protected] Roll src/third_party/skia 5f56cb1d3b4f..f5132a05c893 (6 commits) (flutter/engine#17999)
2020-04-28 [email protected] Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews (flutter/engine#17988)
2020-04-28 [email protected] Roll src/third_party/skia 81ef385c1fcd..5f56cb1d3b4f (14 commits) (flutter/engine#17991)
2020-04-28 [email protected] Roll Dart to 726d3c772554924f62db0b9e0d4c280dbbddc824 (flutter/engine#17993)
2020-04-28 [email protected] Trial PR to enable null safety unfork in the Dart SDK. (flutter/engine#17818)
2020-04-28 [email protected] Roll fuchsia/sdk/core/linux-amd64 from eapIV... to 3h-X9... (flutter/engine#17987)
2020-04-28 [email protected] Set SkSL asset manager in RunConfiguration ctor (flutter/engine#17948)
2020-04-28 [email protected] Started ignoring remote keyboard notifications. (flutter/engine#17981)
2020-04-27 [email protected] Reenable flutter scenic test to identify crashes and follow up on fixes. (flutter/engine#17979)
2020-04-27 [email protected] Update buildroot (flutter/engine#17978)
2020-04-27 [email protected] Roll src/third_party/skia 78debd6f6d83..81ef385c1fcd (1 commits) (flutter/engine#17976)
2020-04-27 [email protected] [web] Don't allow empty initial route (flutter/engine#17936)
2020-04-27 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 9O3Ef... to arZdZ... (flutter/engine#17975)
2020-04-27 [email protected] Roll src/third_party/skia 981d590e8eba..78debd6f6d83 (5 commits) (flutter/engine#17972)
2020-04-27 [email protected] Manual roll of Dart to 03429b20cd67f85d65cc589b529ab8c1a4780912...a53d336b9fd4bbb415d2f1e3f4c653aa107f31c7 (flutter/engine#17971)
2020-04-27 [email protected] Roll src/third_party/skia 1ae3e75a0b4c..981d590e8eba (1 commits) (flutter/engine#17968)
2020-04-27 [email protected] Add initial unit tests for the android embedding (flutter/engine#17921)
2020-04-27 [email protected] Roll src/third_party/dart 2e438d1baffc..a53d336b9fd4 (4 commits) (flutter/engine#17967)
2020-04-26 [email protected] Roll src/third_party/skia 97cfb05aabe4..1ae3e75a0b4c (2 commits) (flutter/engine#17966)
2020-04-26 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 2CE6x... to 9O3Ef... (flutter/engine#17963)
2020-04-26 [email protected] Roll src/third_party/skia c12aad9485a9..97cfb05aabe4 (3 commits) (flutter/engine#17957)
2020-04-26 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 9-v-E... to 2CE6x... (flutter/engine#17955)
2020-04-25 [email protected] Roll src/third_party/dart 216e3df4526c..2e438d1baffc (7 commits) (flutter/engine#17950)
2020-04-25 [email protected] Change the repo fetch script used in integration tests (flutter/engine#17943)
2020-04-24 [email protected] Roll src/third_party/skia 1e21d14f2b8b..c12aad9485a9 (20 commits) (flutter/engine#17942)
2020-04-24 [email protected] Roll src/third_party/dart a69cb6d700f5..216e3df4526c (16 commits) (flutter/engine#17945)
2020-04-24 [email protected] Fix accessibility focus loss when first focusing on text field (flutter/engine#17803)
2020-04-24 [email protected] Roll fuchsia/sdk/core/linux-amd64 from _dAFU... to G4HpJ... (flutter/engine#17938)
2020-04-24 [email protected] [web] Fix exception when getting boxes for rich text range (flutter/engine#17933)
2020-04-24 [email protected] [web] Batch systemFontChange messages (flutter/engine#17885)

0c35a34 Roll src/third_party/skia f5132a05c893..4baa7326ccfb (1 commits) (flutter#18003)
f07712b Roll src/third_party/skia 5f56cb1d3b4f..f5132a05c893 (6 commits) (flutter#17999)
103c9c7 Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews (flutter#17988)
a1fdff6 Roll src/third_party/skia 81ef385c1fcd..5f56cb1d3b4f (14 commits) (flutter#17991)
22479ca Roll Dart to 726d3c772554924f62db0b9e0d4c280dbbddc824 (flutter#17993)
494a63c Trial PR to enable null safety unfork in the Dart SDK. (flutter#17818)
887efcb Roll fuchsia/sdk/core/linux-amd64 from eapIV... to 3h-X9... (flutter#17987)
50ae2b9 Set SkSL asset manager in RunConfiguration ctor (flutter#17948)
5f437fb Started ignoring remote keyboard notifications. (flutter#17981)
027eff8 Reenable flutter scenic test to identify crashes and follow up on fixes. (flutter#17979)
992a55c Update buildroot (flutter#17978)
d5587df Roll src/third_party/skia 78debd6f6d83..81ef385c1fcd (1 commits) (flutter#17976)
aa00d50 [web] Don't allow empty initial route (flutter#17936)
3b0e415 Roll fuchsia/sdk/core/mac-amd64 from 9O3Ef... to arZdZ... (flutter#17975)
66af9ea Roll src/third_party/skia 981d590e8eba..78debd6f6d83 (5 commits) (flutter#17972)
732bf22 Manual roll of Dart to 03429b20cd67f85d65cc589b529ab8c1a4780912...a53d336b9fd4bbb415d2f1e3f4c653aa107f31c7 (flutter#17971)
cad81c7 Roll src/third_party/skia 1ae3e75a0b4c..981d590e8eba (1 commits) (flutter#17968)
eed05dd Add initial unit tests for the android embedding (flutter#17921)
168a65f Roll src/third_party/dart 2e438d1baffc..a53d336b9fd4 (4 commits) (flutter#17967)
742adb8 Roll src/third_party/skia 97cfb05aabe4..1ae3e75a0b4c (2 commits) (flutter#17966)
805ef7c Roll fuchsia/sdk/core/mac-amd64 from 2CE6x... to 9O3Ef... (flutter#17963)
11c6a18 Roll src/third_party/skia c12aad9485a9..97cfb05aabe4 (3 commits) (flutter#17957)
4e29e57 Roll fuchsia/sdk/core/mac-amd64 from 9-v-E... to 2CE6x... (flutter#17955)
4f3b929 Roll src/third_party/dart 216e3df4526c..2e438d1baffc (7 commits) (flutter#17950)
4f888d6 Change the repo fetch script used in integration tests (flutter#17943)
3999ef9 Roll src/third_party/skia 1e21d14f2b8b..c12aad9485a9 (20 commits) (flutter#17942)
d01de3b Roll src/third_party/dart a69cb6d700f5..216e3df4526c (16 commits) (flutter#17945)
2589d07 Fix accessibility focus loss when first focusing on text field (flutter#17803)
3af2b1a Roll fuchsia/sdk/core/linux-amd64 from _dAFU... to G4HpJ... (flutter#17938)
d132ac5 [web] Fix exception when getting boxes for rich text range (flutter#17933)
cade0e9 [web] Batch systemFontChange messages (flutter#17885)
@fluttergithubbot fluttergithubbot added the engine flutter/engine related. See also e: labels. label Apr 28, 2020
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino merged commit 8cbba0a into flutter:master Apr 28, 2020
@christopherfujino christopherfujino deleted the manual-engine-roll branch April 28, 2020 20:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants