Pass RouteSettings to the internal Route in showCupertinoModalPopup#56024
Merged
goderbauer merged 8 commits intoflutter:masterfrom Oct 12, 2020
miquelbeltran:mb-cupertinomodal-settings
Merged
Pass RouteSettings to the internal Route in showCupertinoModalPopup#56024goderbauer merged 8 commits intoflutter:masterfrom miquelbeltran:mb-cupertinomodal-settings
goderbauer merged 8 commits intoflutter:masterfrom
miquelbeltran:mb-cupertinomodal-settings
Conversation
goderbauer
added
f: cupertino
|
This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it. |
Member
Author
|
Hi @goderbauer, is the a change I can get a review? the code is not a huge change but helps to 1:1 the Cupertino and Material APIs |
goderbauer
reviewed
Oct 1, 2020
| ImageFilter filter, | ||
| bool useRootNavigator = true, | ||
| bool semanticsDismissible, | ||
| RouteSettings settings, |
Member
There was a problem hiding this comment.
To keep the naming consistent with the other showFoo methods, can we also call this here routeSettings?
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I add the missing
RouteSettingsparameter to theshowCupertinoModalPopupmethod.This parameter already existed in the internal
_CupertinoModalPopupRoutebut it was not exposed.It is useful to expose this parameter to provide the route name to the newly created
Route.As example, the Material
showDialogfunction acceptsRouteSettingsas well.Related Issues
No related issues.
Tests
Added a test that obtains the route name from the
RouteSettingspassed to theshowCupertinoModalPopupcall and compares it to the expected value, to verify that the value is correctly passed.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.