Closed
Conversation
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
on L109 a BuildInfo is constructed from mode/flavor and tree shake icons. That needs to be updated to do everything that https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/runner/flutter_command.dart#L543 does
| : '1.0'; | ||
|
|
||
| for (final String buildMode in const <String>['debug', 'profile', 'release']) { | ||
| const Map<String, BuildInfo> buildModes = {'debug': BuildInfo.debug, 'profile': BuildInfo.profile, 'release': BuildInfo.release}; |
Contributor
There was a problem hiding this comment.
You're still using default values here, you'll need to explicitly construct a build info with all of the parameters set that you care about:
Member
Author
There was a problem hiding this comment.
seems like that's what build_ios_framework is doing too. Does that one need refactoring too?
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.