[flutter_tools] make gallery hot reload 5x faster with one neat trick#56224
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom May 4, 2020
Merged
[flutter_tools] make gallery hot reload 5x faster with one neat trick#56224jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams merged 1 commit intoflutter:masterfrom
Conversation
Contributor
Author
|
NVM, i misread the code, we waited forever lol. I wonder if instead we should wait for isolate runnable? |
Contributor
Author
|
Commented on the wrong issue. |
Contributor
Author
|
FYI @willlarche hot reload in the gallery app should be noticeably faster now. |
Contributor
|
How'd you find this one? |
Contributor
Author
|
I just was running the gallery to debug the service worker issues and I noticed it was taking way too long |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AssetBundle tracks whether any changes to wildcard directories necessitate rebuilding the asset bundle. Rebuilding should be avoid since it can be quite expensive even if the assets haven't changed.
However there was a bug! We (I) tracked the wrong directory for dependent packages, meaning everytime we checked if the asset bundle needed to be built, we saw a "newly missing" wildcard and said yes.
These don't even need to be tracked!