[devicelab] unmark android_attach, twc tests, remove mac twc test#56401
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom May 6, 2020
Merged
[devicelab] unmark android_attach, twc tests, remove mac twc test#56401fluttergithubbot merged 4 commits intoflutter:masterfrom
fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
| required_agent_capabilities: ["mac/ios"] | ||
| flaky: true | ||
|
|
||
| mac_enable_twc: |
Contributor
There was a problem hiding this comment.
should we have a TODO to re-enable?
Contributor
Author
There was a problem hiding this comment.
Done, and moved to correct section
christopherfujino
approved these changes
May 5, 2020
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, with an optional nit about leaving a TODO for the removed test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The android attach test is fixed, and the ios/android twc tests are non-flaky. I don't have time to debug the mac twc issue but it seems like it will be difficult remotely so I'm removing from the dashboard for now.
(technically already fixed)
Fixes #55875
Fixes #56322