Bring back paste button hide behavior#56689
Merged
justinmc merged 2 commits intoflutter:masterfrom May 8, 2020
Merged
Conversation
…4902)" (flutter#56614)" This reverts commit cd67da2.
fluttergithubbot
added
f: cupertino
…add a case with clipboard content to it
fluttergithubbot
added
a: accessibility
goderbauer
approved these changes
May 8, 2020
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Gotta say, it makes me happy that we have an integration test that caught this! (@jonahwilliams 🎉)
mehmetf
added a commit
that referenced
this pull request
May 10, 2020
justinmc
added a commit
to justinmc/flutter
that referenced
this pull request
May 11, 2020
flutter#56806)" This reverts commit 0786f29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#54902 was reverted by #56614 because it caused an integration test to fail after it was merged. This brings it back.
The only change is to update the android_semantics_test integration test to include a case with/without content on the clipboard.