Always remove the workspace settings when set to legacy build settings#56703
Merged
jmagman merged 1 commit intoflutter:masterfrom May 8, 2020
Merged
Always remove the workspace settings when set to legacy build settings#56703jmagman merged 1 commit intoflutter:masterfrom
jmagman merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
May 12, 2020
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
May 12, 2020
pcsosinski
pushed a commit
that referenced
this pull request
May 13, 2020
* Always remove the workspace settings (#56703) * [flutter_tools] hide tree-shake-icons (#56924) * fix pushAndRemoveUntil incorrectly removes the routes below the first… (#56732) * Update engine hash for 1.17.1 * fix customer_testing-windows Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: chunhtai <[email protected]>
pcsosinski
pushed a commit
that referenced
this pull request
May 13, 2020
* Always remove the workspace settings (#56703) * [flutter_tools] hide tree-shake-icons (#56924) * fix pushAndRemoveUntil incorrectly removes the routes below the first… (#56732) * let the embedding maven engine dependency reference the storage proxy (#56164) * typo fix on the FLUTTER_STORAGE_BASE_URL usage (#56685) * Update engine hash for 1.18.0-11.1.pre Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: chunhtai <[email protected]> Co-authored-by: xster <[email protected]> Co-authored-by: Luke Cheng <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make #52288 migration more aggressive by always deleting the workspace settings when it's set to the legacy build system. Xcode likes to add keys to this file like
PreviewsEnabled.Reset to defaults by removing this file. There's not usually anything interesting in this file, and Xcode will add whatever it wants next time it opens, but it won't reset the
BuildSystemTypeto Original so this migration will only run once.Related Issues
#56567 and duplicates.
Tests
Updated ios_project_migration_test.dart
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change