fix roll_dev.dart to query remote ref, rather than local#56721
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom May 11, 2020
Merged
fix roll_dev.dart to query remote ref, rather than local#56721fluttergithubbot merged 1 commit intoflutter:masterfrom
roll_dev.dart to query remote ref, rather than local#56721fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
c: contributor-productivity
jmagman
approved these changes
May 8, 2020
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Locally:
$ git describe --exact-match --tags refs/remotes/upstream/dev
1.19.0-0.0.pre
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I introduced a bug with #56501 where the script would query the local ref
refs/heads/dev, when it should have been the remote refrefs/remotes/<remote_name>/dev.Issues
Fixes #56705
Tests
Updated existing tests.