Closed
Conversation
Contributor
Author
|
This wouldn't be landed until we're ready with the bash implementation too |
goderbauer
reviewed
May 11, 2020
bin/dart.bat
Outdated
| SET shared_bin=%FLUTTER_ROOT%/bin/internal/shared.bat | ||
| CALL "%shared_bin%" | ||
|
|
||
| SET flutter_tools_dir=%FLUTTER_ROOT%\packages\flutter_tools |
Member
There was a problem hiding this comment.
nit: some of the variables set here seem unused? e.g. snapshot_path and engine_stamp
bin/dart.bat
Outdated
| REM ---------------------------------- NOTE ---------------------------------- | ||
| REM | ||
| REM Please keep the logic in this file consistent with the logic in the | ||
| REM `flutter` script in the same directory to ensure that Flutter continues to |
Member
There was a problem hiding this comment.
Does this comment need updating (i.e. is the linux side also getting restructured?)
bin/internal/shared.bat
Outdated
| REM ---------------------------------- NOTE ---------------------------------- | ||
| REM | ||
| REM Please keep the logic in this file consistent with the logic in the | ||
| REM `flutter` script in the same directory to ensure that Flutter continues to |
Member
There was a problem hiding this comment.
this may need updating (see other comment)
zanderso
approved these changes
May 11, 2020
goderbauer
added
the
tool
Contributor
Author
|
Updated to remove unused variables, and reference update pwsh location and disable-dartdev for flutter. |
13 tasks
Contributor
Author
|
This was pulled into @christopherfujino 's change to land in one go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The windows implementation of placing a dart executable on the PATH. This moves all of the shared logic into internal/shared.bat and adds a CALL to invoke this from both flutter.bat and dart.bat.
To keep the code simple, the bootstrap process is identical whether calling into dart or flutter.