Skip to content

Revert "Bring back paste button hide behavior 2"#56951

Merged
jmagman merged 1 commit intomasterfrom
revert-56922-pasteable-revert-revert-2
May 11, 2020
Merged

Revert "Bring back paste button hide behavior 2"#56951
jmagman merged 1 commit intomasterfrom
revert-56922-pasteable-revert-revert-2

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 11, 2020

Reverts #56922

2020-05-11T14:41:55.457819: stdout: [+1992 ms] 00:09 �[32m+0�[0m�[31m -1�[0m: AccessibilityBridge TextField TextField has correct Android semantics �[1m�[31m[E]�[0m�[0m
2020-05-11T14:41:55.457984: stdout: [        ]   Expected: AndroidSemanticsNode with className: android.widget.EditText with actions: [AndroidSemanticsAction.clearAccessibilityFocus, AndroidSemanticsAction.click, AndroidSemanticsAction.setSelection] with flag isEditable: true with flag isFocusable: true with flag isFocused: true with flag isPassword: false
2020-05-11T14:41:55.458259: stdout: [        ]     Actual: AndroidSemanticsNode:<{flags: {isEditable: true, isEnabled: true, isDismissable: false, isCheckable: false, isChecked: false, isFocused: true, isLongClickable: false, isFocusable: true, isPassword: false}, id: 14, text: null, rect: {height: 144, width: 1080, bottom: 128.0, top: 80.0, left: 0.0, right: 360.0}, actions: [131072, 32768, 16, 128], className: android.widget.EditText, liveRegion: 1, contentDescription: null}>
2020-05-11T14:41:55.458442: stdout: [        ]      Which: Expected actions: [AndroidSemanticsAction.clearAccessibilityFocus, AndroidSemanticsAction.click, AndroidSemanticsAction.setSelection]
2020-05-11T14:41:55.458710: stdout: [        ]             Actual actions: [AndroidSemanticsAction.clearAccessibilityFocus, AndroidSemanticsAction.click, AndroidSemanticsAction.copy, AndroidSemanticsAction.setSelection]
2020-05-11T14:41:55.458935: stdout: [        ]             Unexpected: {AndroidSemanticsAction.copy}
2020-05-11T14:41:55.459211: stdout: [        ]             Missing: {}

android_semantics_integration_test_d988226_2.log

@jmagman jmagman requested a review from justinmc May 11, 2020 22:27
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 11, 2020
@jmagman
Copy link
Member Author

jmagman commented May 11, 2020

Merging to green the build.

@jmagman jmagman merged commit c969b8a into master May 11, 2020
@jmagman jmagman deleted the revert-56922-pasteable-revert-revert-2 branch May 11, 2020 22:28
justinmc added a commit to justinmc/flutter that referenced this pull request May 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants