Making DropdownButtonFormField to re-render if parent widget changes by pedromassango · Pull Request #57037 · flutter/flutter

pedromassango · 2020-05-12T18:35:59Z

Description

I'm just making DropdownButtonFormField to show new value by overriding the didUpdateWidget() function and replacing the current value with the new widget instance's value.

Related Issues

Fixes #56898
Fixes #56716

Tests

I added the following tests:

A test to ensure that the rendered DropdownButtonFormField contains updated text from the passed in value.

Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

No, no existing tests failed, so this is not a breaking change.

fluttergithubbot · 2020-05-12T18:36:03Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

packages/flutter/test/material/dropdown_form_field_test.dart

Co-authored-by: Shi-Hao Hong <[email protected]>

packages/flutter/test/material/dropdown_form_field_test.dart

Co-authored-by: Shi-Hao Hong <[email protected]>

shihaohong

LGTM!

shihaohong · 2020-05-12T20:48:27Z

@pedromassango The PR seems to be failing analyze-linux. Could you fix the analyzer issues in the PR?

pedromassango · 2020-05-12T20:50:50Z

@pedromassango The PR seems to be failing analyze-linux. Could you fix the analyzer issues in the PR?

Of course

pedromassango · 2020-05-12T22:00:27Z

@shihaohong looks like there is something wrong with Flutter build task!

shihaohong · 2020-05-12T22:04:17Z

@pedromassango That's okay. flutter-build indicates whether or not the latest build of Flutter is passing all tests or not. It failing means that one of the recent PRs might have broken tests, or that the infrastructure is not functioning as expected or is down.

Since I applied the waiting for tree to go green label, this PR will be merged as soon as the tree is green.

shihaohong · 2020-05-12T22:05:03Z

Thanks again for your contribution!

pedromassango · 2020-05-12T22:05:36Z

@pedromassango That's okay. flutter-build indicates whether or not the latest build of Flutter is passing all tests or not. It failing means that one of the recent PRs might have broken tests, or that the infrastructure is not functioning as expected or is down.

Since I applied the waiting for tree to go green label, this PR will be merged as soon as the tree is green.

Thank you for the clarification

jlubeck · 2020-05-13T16:55:35Z

@shihaohong What would be the proper way to follow this PR landing on Beta???

shihaohong · 2020-05-13T17:06:44Z

@jlubeck Here is the general guideline for beta releases: https://github.com/flutter/flutter/wiki/Flutter-build-release-channels#beta, but basically, there should be a beta release roughly once a month.

jlubeck · 2020-05-13T18:27:28Z

@shihaohong ok, so there is no notification or something that would tell me when this got merged into Beta?

shihaohong · 2020-05-13T18:33:49Z

@jlubeck I think the flutter-announce google group is your best bet. New releases and breaking change announcements are made through that channel.

jlubeck · 2020-05-13T18:35:38Z

Thank you @shihaohong
Great work by the way

jlubeck · 2020-05-14T18:40:12Z

Hey @shihaohong sorry to bug you one last time. I guess this is more of a general github usage question? I just saw that a new Flutter 1.18.0-11.1.pre release got pushed to the beta channel. My question was mainly how can I check that this PR is included in that release?

shihaohong · 2020-05-14T18:44:55Z

@jlubeck You can see the commit list on GitHub: https://github.com/flutter/flutter/commits/beta

I don't think this made it into the latest beta release.

…lutter#57037) * Update DropdownButtonFormField's state if widget updates Co-authored-by: Shi-Hao Hong <[email protected]>

* fix segment hit test behavior (#57461) * Making DropdownButtonFormField to re-render if parent widget changes (#57037) * Update DropdownButtonFormField's state if widget updates Co-authored-by: Shi-Hao Hong <[email protected]> * throw more specific toolexit when git fails during upgrade (#57162) * [flutter_tools] Refresh VM state before executing hot reload (#53960) * Update engine hash for 1.17.2 * Remove MaterialControls from examples/flutter_view (#57621) Co-authored-by: Jenn Magder <[email protected]> * Prevent building non-android plugins in build aar (#58018) * Allow FLUTTER_APPLICATION_PATH to be null for misconfigured Xcode projects (#57701) * Don't import plugins that don't support android in settings.gradle (#54407) Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Pedro Massango <[email protected]> Co-authored-by: Shi-Hao Hong <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: stuartmorgan <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]>

Update DropdownButtonFormField's state if widget changes

c8a74f5

fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 12, 2020

googlebot added the cla: yes label May 12, 2020

Added tests

28b92c3

pedromassango mentioned this pull request May 12, 2020

Making DropdownButtonFormField to re-render if parent widget changes pedromassango/flutter#1

Closed

9 tasks

shihaohong reviewed May 12, 2020

View reviewed changes

shihaohong added found in release: 1.17 Found to occur in 1.17 found in release: 1.18 Occurs in 1.18 c: regression It was better in the past than it is now labels May 12, 2020

shihaohong self-assigned this May 12, 2020

pedromassango and others added 5 commits May 12, 2020 20:02

Update packages/flutter/test/material/dropdown_form_field_test.dart

ae9cb95

Co-authored-by: Shi-Hao Hong <[email protected]>

Update packages/flutter/test/material/dropdown_form_field_test.dart

fd2e158

Co-authored-by: Shi-Hao Hong <[email protected]>

Removed unnecessary code for test

9f00494

asserting that the dropdown show the new value

ec461be

provide a default value for onChanged

e82b3b3

shihaohong reviewed May 12, 2020

View reviewed changes

pedromassango and others added 2 commits May 12, 2020 21:19

Update packages/flutter/test/material/dropdown_form_field_test.dart

3de4b01

Co-authored-by: Shi-Hao Hong <[email protected]>

Added comments

283d015

shihaohong approved these changes May 12, 2020

View reviewed changes

shihaohong mentioned this pull request May 12, 2020

Allow DropdownButtonFormField's value to be set programmatically #57031

Closed

13 tasks

Removed trailing spaces

a99931e

shihaohong added the waiting for tree to go green label May 12, 2020

shihaohong merged commit 1aaf73f into flutter:master May 13, 2020

shihaohong mentioned this pull request May 13, 2020

DropdownButtonFormField Multi-Level Dependent crash #57066

Closed

pedromassango deleted the patch-2 branch May 13, 2020 17:53

HansMuller mentioned this pull request May 20, 2020

DropdownButtonFormField does not update #57615

Closed

tvolkert mentioned this pull request May 20, 2020

DropdownButtonFormField is not re-rendered after value is changed programmatically #56898

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021

Conversation

pedromassango commented May 12, 2020 • edited by shihaohong Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

fluttergithubbot commented May 12, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shihaohong left a comment

Choose a reason for hiding this comment

Uh oh!

shihaohong commented May 12, 2020

Uh oh!

pedromassango commented May 12, 2020

Uh oh!

pedromassango commented May 12, 2020

Uh oh!

shihaohong commented May 12, 2020

Uh oh!

shihaohong commented May 12, 2020

Uh oh!

pedromassango commented May 12, 2020

Uh oh!

jlubeck commented May 13, 2020

Uh oh!

shihaohong commented May 13, 2020

Uh oh!

jlubeck commented May 13, 2020

Uh oh!

shihaohong commented May 13, 2020

Uh oh!

jlubeck commented May 13, 2020

Uh oh!

jlubeck commented May 14, 2020

Uh oh!

shihaohong commented May 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pedromassango commented May 12, 2020 •

edited by shihaohong

Loading