Slider value indicator gets disposed if it is activated#57535
Merged
fluttergithubbot merged 6 commits intoflutter:masterfrom May 27, 2020
Merged
Slider value indicator gets disposed if it is activated#57535fluttergithubbot merged 6 commits intoflutter:masterfrom
fluttergithubbot merged 6 commits intoflutter:masterfrom
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
rami-a
reviewed
May 20, 2020
rami-a
approved these changes
May 20, 2020
HansMuller
reviewed
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Slider value indicator gets disposed even if the value indicator is active. Currently if the Slider gets removed while it is activated than the value indicator remains on the Overlay.
Related Issues
Closes #55787
Tests
I added the following tests:
flutter/packages/flutter/test/material/slider_test.darttest using context 'Slider removes value indicator from overlay if Slider gets disposed without value indicator animation completing.'
flutter/packages/flutter/test/material/range_slider_test.darttest using context 'Range Slider removes value indicator from overlay if Slider gets disposed without value indicator animation completing.'
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.