Add mouse cursor API to widgets (phase 1)#57628
Merged
dkwingsmt merged 17 commits intoflutter:masterfrom May 28, 2020
Merged
Conversation
17 tasks
HansMuller
reviewed
May 26, 2020
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
This look good, just wanted to consider merging the two MaterialState cursor classes.
Contributor
Author
|
@HansMuller I made |
Contributor
|
Thanks, will take a look. I wasn't able to come up with a better name than MaterialStateMouseCursor.clickable. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds default cursor and/or
mouseCursorproperty to a number of widgets.This PR also adds
MaterialStateMouseCursor, which is a mouse cursor that depends on material states, as well asClickableMouseCursor, which is a material state mouse cursor that isclicknormally butbasicwhen disabled.The complete list of widgets are as follows:
basic)text)text)Open question
ClickableMouseCursor?MaterialStateMouseCursorin a currying-like way so that the states ofInkResponsecan be directly used?Related Issues
Tests
I added the following tests:
mouseCursorpropertyClickableMouseCursor, then the widget displays the correct cursor when disabled.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.