[flutter_tools] URI encode dart-define values#57873
Merged
jmagman merged 3 commits intoflutter:masterfrom May 27, 2020
Merged
Conversation
fluttergithubbot
added
tool
zanderso
approved these changes
May 26, 2020
| String getFuchsiaBuildDirectory() { | ||
| return globals.fs.path.join(getBuildDirectory(), 'fuchsia'); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
joining with commas is not sufficient, since it seems certain characters like URLs cause some escaping issues with xcode. URI the values to work around this
Fixes #57812