Set upper limit on text scaling for AppBar.title#58094
Merged
fluttergithubbot merged 12 commits intoflutter:masterfrom Jun 18, 2020
Merged
Set upper limit on text scaling for AppBar.title#58094fluttergithubbot merged 12 commits intoflutter:masterfrom
fluttergithubbot merged 12 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
f: material design
perclasson
changed the title
guidezpl
reviewed
May 27, 2020
guidezpl
reviewed
May 27, 2020
guidezpl
approved these changes
May 27, 2020
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
██╗ ██████╗ ████████╗███╗ ███╗
██║ ██╔════╝ ╚══██╔══╝████╗ ████║
██║ ██║ ███╗ ██║ ██╔████╔██║
██║ ██║ ██║ ██║ ██║╚██╔╝██║
███████╗╚██████╔╝ ██║ ██║ ╚═╝ ██║
╚══════╝ ╚═════╝ ╚═╝ ╚═╝ ╚═╝
perclasson
force-pushed
the
app_bar_max_text_font_size
branch
from
141c0ed to
98d7922
Compare
HansMuller
approved these changes
Jun 3, 2020
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM so long as it really doesn't break any existing internal or external tests.
| child: title, | ||
| ); | ||
|
|
||
| // Set maximum text scale factor to [_kMaxTitleTextScaleFactor] for the |
Contributor
There was a problem hiding this comment.
This comment doesn't help developers reading the API docs however it's an odd enough corner case that I think it's OK to leave it as it is - a private implementation comment.
perclasson
force-pushed
the
app_bar_max_text_font_size
branch
from
f03d9eb to
9d7d260
Compare
HansMuller
approved these changes
Jun 17, 2020
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM
The PRs description should explain what you're doing with the deprecated, default false, shouldCapTextScaleForTitle, property. Remind developers that it's just temporary while we roll this change through.
guidezpl
approved these changes
Jun 18, 2020
perclasson
added
waiting for tree to go green
and removed
waiting for tree to go green
labels
perclasson
force-pushed
the
app_bar_max_text_font_size
branch
from
9d7d260 to
dbd8c60
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
10 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To follow the Material spec the title of AppBars should have a upper limit of x1.34 text scaling to keep the visual hierarchy in an application. The deprecated property
shouldCapTextScaleForTitlethat is false by default, was added for backwards compatibility with internal tests. After this PR has merged, it will be changed to true by default in one PR, and then removed in one afterwards. So it is just temporary while this change rolls through and should not be used by external developers.For example, having the font size of 18, is 24 with maximum text scaling.
AppBar without text scaling:
With text scaling, but capped at 1.34:
Related Issues
Closes #58093
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.