Add a backward variant of BenchCardInfiniteScroll#58140
Merged
yjbanov merged 1 commit intoflutter:masterfrom May 28, 2020
Merged
Add a backward variant of BenchCardInfiniteScroll#58140yjbanov merged 1 commit intoflutter:masterfrom
yjbanov merged 1 commit intoflutter:masterfrom
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
c: contributor-productivity
This was referenced May 28, 2020
yjbanov
force-pushed
the
bench-scroll-backward
branch
from
740be45 to
623340a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a variant of
BenchCardInfiniteScrollthat scrolls backwards. This correlates with the scrolling issue described in #55922. When we scroll backwards our DOM update logic hits a noticeable performance cliff by causing more child node moves than necessary.Related Issues
#55922