Skip to content

Detect USB/network interface from iOS devices#58257

Merged
jmagman merged 2 commits intoflutter:masterfrom
jmagman:wireless-detection
May 29, 2020
Merged

Detect USB/network interface from iOS devices#58257
jmagman merged 2 commits intoflutter:masterfrom
jmagman:wireless-detection

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 29, 2020

Description

Detect whether the iOS device is connected via USB or network.
The wireless devices aren't returned from getAvailableIOSDevices() yet since observatory discovery isn't yet hooked up.

Related Issues

Next part of #15072.

Building on:
#49854
#51015
#51678

Tests

Added ios_device_install_test.dart, updated other call sites

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels May 29, 2020
@jmagman jmagman requested a review from christopherfujino May 29, 2020 18:06
@jmagman jmagman self-assigned this May 29, 2020
christopherfujino
christopherfujino reviewed May 29, 2020
View reviewed changes
packages/flutter_tools/lib/src/ios/devices.dart Outdated
Copy link
Contributor

@christopherfujino christopherfujino May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is none exclusively simulators?

Copy link
Member Author

@jmagman jmagman May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK but it's also a fallback in case they add some new type we can't parse.

Copy link
Member Author

@jmagman jmagman May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a clarifying comment.

Copy link
Contributor

@christopherfujino christopherfujino May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jmagman jmagman force-pushed the wireless-detection branch from 4afa1b4 to be128f7 Compare May 29, 2020 19:25
christopherfujino
christopherfujino approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman mentioned this pull request May 29, 2020
Closed
@jmagman jmagman merged commit b0c98b6 into flutter:master May 29, 2020
@jmagman jmagman deleted the wireless-detection branch May 29, 2020 22:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @christopherfujino @googlebot